John Mills
- Bright Young Things
2003 Gentleman
- The Gentleman Thief
2001 Arthur Rosehip
- A Profile of In Which We Serve
2000 Interviewee
- Cats
1998 Gus the Theatre Cat
- Bean
1997 Chairman
- Hamlet
1996 Old King Norway
- The Grotesque
1995 Sir Edward Cleghorn
- Deadly Advice
1994 Jack the Ripper
- Frankenstein
1993 De Lacey
- The Big Freeze
1993 Dapper man
- Harnessing Peacocks
1993 Bernard Quigley
- Night of the Fox
1990 Brig. Dougal Munro
- Ending Up
1989 Bernard
- The Lady and the Highwayman
1988 Sir Lawrence Dobson
- Who's That Girl
1987 Montgomery Bell
- When the Wind Blows
1986 Jim Bloggs (voice)
- Murder with Mirrors
1985 Lewis Serrocold
- The Masks of Death
1984 Dr. John H. Watson / Narrator
- Sahara
1983 Cambridge
- Gandhi
1982 Lord Chelmsford
- The Quatermass Conclusion
1979 Prof. Bernard Quatermass
- Zulu Dawn
1979 Sir Henry Bartle Frere
- The Big Sleep
1978 Inspector Carson
- The Thirty Nine Steps
1978 Scudder
- Dr. Strange
1978 Thomas Lindmer
- The Devil's Advocate
1977 Monsignor Blaise Meredith
- Trial by Combat
1976 Colonel Bertie Cook
- The Human Factor
1975 Mike McAllister
- Oklahoma Crude
1973 Cleon Doyle
- Young Winston
1972 General Kitchner
- Lady Caroline Lamb
1972 Canning
- Dulcima
1971 Mr. Parker
- Ryan's Daughter
1970 Michael
- Adam's Woman
1970 Sir Philip MacDonald
- Oh! What a Lovely War
1969 Field Marshall Sir Douglas Haig
- Run Wild, Run Free
1969 The Moorman (Colonel)
- Emma Hamilton
1968 Lord William Hamilton
- A Black Veil for Lisa
1968 Inspector Franz Bulon
- Chuka
1967 Colonel Stuart Valois
- Africa: Texas Style!
1967 Wing Commander Hayes
- The Wrong Box
1966 Masterman Finsbury
- The Family Way
1966 Ezra Fitton
- Sky West and Crooked
1966 Director
- King Rat
1965 Smedley-Taylor
- Operation Crossbow
1965 General Boyd
- The Truth About Spring
1965 Tommy Tyler
- The Chalk Garden
1964 Maitland
- Tiara Tahiti
1962 Lt. Col. Clifford Southey
- The Valiant
1962 Captain Morgan
- The Singer Not the Song
1961 Father Michael Keogh
- Flame in the Streets
1961 Jacko Palmer
- The Parent Trap
1961 Mitch Evers' Golf Caddy (uncredited)
- Tunes of Glory
1960 Lt. Col. Basil Barrow (Battalion Commander)
- Swiss Family Robinson
1960 Father
- Tiger Bay
1959 Superintendent Graham
- Summer of the Seventeenth Doll
1959 Barney
- Ice Cold in Alex
1958 Captain Anson
- Dunkirk
1958 Cpl Tubby Binns
- I Was Monty's Double
1958 Major Harvey
- Town on Trial
1957 Supt. Mike Halloran
- The Vicious Circle
1957 Dr. Howard Latimer
- War and Peace
1956 Platon Karataev
- The Baby and the Battleship
1956 Puncher Roberts
- Around the World in 80 Days
1956 London Carriage Driver
- It's Great to be Young!
1956 Dingle
- The Letter
1956 Robert Crosbie
- Above Us the Waves
1955 Commandant Fraser
- The Colditz Story
1955 Pat Reid
- The End of the Affair
1955 Albert Parkis
- Escapade
1955 John Hampden
- Hobson's Choice
1954 William Mossop
- The Long Memory
1953 Phillip Davidson
- The Gentle Gunman
1952 Terence Sullivan
- Mr. Denning Drives North
1951 Tom Denning
- Morning Departure
1950 Lt. Cmdr. Armstrong
- The Rocking Horse Winner
1949 Producer
- The History of Mr. Polly
1949 Alfred Polly
- Scott of the Antarctic
1948 Captain R.F. Scott R.N.
- The October Man
1947 Jim Ackland
- So Well Remembered
1947 George Boswell
- Great Expectations
1946 Pip
- Land of Promise
1946 The Voice
- The Way to the Stars
1945 Pilot Officer Peter Penrose
- Waterloo Road
1945 Jim Colter
- Total War in Britain
1945 Narrator (voice)
- This Happy Breed
1944 Billy Mitchell
- Victory Wedding
1944 Bill Clark
- Information Please
1944 British Flyer
- We Dive at Dawn
1943 Lt. Taylor RN
- The Sky’s the Limit
1943 Tom
- In Which We Serve
1942 Ordinary Seaman Blake / Shorty Blake
- The Black Sheep of Whitehall
1942 Bobby Jessop
- The Big Blockade
1942 Tom
- The Young Mr. Pitt
1942 William Wilberforce
- Cottage to Let
1941 Flt·Lieut. Perry
- Old Bill and Son
1941 Young Bill
- All Hands
1940 Jack
- Goodbye, Mr. Chips
1939 Peter Colley as a Young Man
- Happy Family
1939 Fred
- The Green Cockatoo
1937 Jim Connor
- O.H.M.S.
1937 Cpl. Bert Dawson
- Tudor Rose
1936 Lord Guilford Dudley
- First Offence
1936 Johnnie Penrose
- Royal Cavalcade
1935 Young Enlistee
- Car of Dreams
1935 Robert Miller
- Brown on Resolution
1935 Albert Brown
- Charing Cross Road
1935 Tony
- Blind Justice
1935 Ralph Summers
- Those Were the Days
1934 Bobby Poskett
- Doctor's Orders
1934 Ronnie Blake
- A Political Party
1934 Tony Smithers
- The Lash
1934 Arthur Haughton
- Britannia of Billingsgate
1933 Fred Bolton
- The Ghost Camera
1933 Ernest Elton
- The Midshipmaid
1932 Golightly
